Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carla 1.9.9 (new formula) #31560

Closed
wants to merge 8 commits into from
Closed

carla 1.9.9 (new formula) #31560

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b97c0b4
carla 1.9.9 (new formula)
tresf Aug 29, 2018
dcef8ea
carla: fix style guidelines
tresf Aug 29, 2018
b401069
carla: remove lingering virtualenv
tresf Aug 29, 2018
bb73394
carla: remove ":recommended" per #31510
tresf Aug 29, 2018
5984108
carla: remove obsolete comment, fix style
tresf Aug 29, 2018
35a2e74
carla: add reqeusted corrections
tresf Sep 5, 2018
24cf812
carla: fix deeper test case
tresf Sep 5, 2018
bc53835
carla: fix formatting
tresf Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Formula/carla.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
class Carla < Formula
desc "Audio plugin host supporting LADSPA, LV2, VST2/3, SF2 and more"
homepage "https://kxstudio.linuxaudio.org/Applications:Carla"
url "https://github.com/falkTX/carla", :using => :git, :tag => "v1.9.9", :revision => "c03571a9ef95ac0e9564b95347f5de819aa7fb54"
tresf marked this conversation as resolved.
Show resolved Hide resolved
revision 0
tresf marked this conversation as resolved.
Show resolved Hide resolved

depends_on "pkg-config" => :build
depends_on "fluid-synth"
depends_on "liblo"
depends_on "libmagic"
depends_on :macos => :mavericks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

@tresf tresf Sep 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He's patched this in master, but not in the stable. Should I include the patch now and remove the depends_on :macos => :mavericks flag so that the next version works without formula changes? Please advise.

The update will look something like this:

  def install
    args = []

    # Fix C++11 compilation
    if :macos < :mavericks?
      args << "MACOS_OLD=true"
    end

    system "make", *args
    system "make", "install", "PREFIX=#{prefix}"
  end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per 35a2e74, I've gone ahead and removed this restriction in favor of the MACOS_OLD flag. The developer says this flag will remain for the foreseeable future.

depends_on "pyqt"
depends_on "python"

def install
args = %W[
tresf marked this conversation as resolved.
Show resolved Hide resolved
PREFIX=#{prefix}
]

system "make"
system "make", "install", *args
end

test do
system bin/"carla", "--version"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance of a test that exercises a deeper level of functionality? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library author confirms carla --version is adequate (it uses pyqt, so this will show errors if compilation failed). He's provided me a subsequent test... system bin/"carla-discovery-native", internal, :all. It will be tested locally and added to this PR.

end
end