-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pmix 5.0.2 #166807
pmix 5.0.2 #166807
Conversation
|
2df2844
to
aa98204
Compare
Apple linker regression in Xcode 15.3 Also reported to OpenMPI: open-mpi/ompi#12427 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
aa98204
to
a6be316
Compare
|
||
# Work around asm incompatibility with new linker (FB13194320) | ||
# https://github.com/open-mpi/ompi/issues/11935 | ||
ENV.append "LDFLAGS", "-Wl,-ld_classic" if DevelopmentTools.clang_build_version >= 1500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs to be FCFLAGS
instead (or in addition?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon open-mpi wrapper stuff doesn't read from the environment though so might need to hack the configure file to insert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically: whatever is required to make it appear in share/openmpi/mpifort-wrapper-data.txt
. I edited that file locally and it seems to work.
I tried |
a6be316
to
f1b2b17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
|
@@ -38,6 +39,10 @@ def install | |||
if OS.mac? | |||
# Otherwise libmpi_usempi_ignore_tkr gets built as a static library | |||
ENV["MACOSX_DEPLOYMENT_TARGET"] = MacOS.version | |||
|
|||
# Work around asm incompatibility with new linker (FB13194320) | |||
# https://github.com/open-mpi/ompi/issues/11935 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this issue reference seems wrong?
relates to #166807 Signed-off-by: Rui Chen <rui@chenrui.dev>
Created by
brew bump
Created with
brew bump-formula-pr
.