-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go@1.21 1.21.7 (new formula) #162713
go@1.21 1.21.7 (new formula) #162713
Conversation
there are some test failures with |
IMO we should handle the problematic 3 formulae separately from this PR. Should I move them to separate PRs? |
yeah, you can. (I actually already did one) |
@@ -20,7 +20,7 @@ class Clair < Formula | |||
sha256 cellar: :any_skip_relocation, x86_64_linux: "bb434c8789c0d0b1fe858eb2573cd97a9c52cf34b04872b03126a10ace8f43b6" | |||
end | |||
|
|||
depends_on "go" => :build | |||
depends_on "go@1.21" => :build # use "go" again when https://github.com/quay/clair/pull/1942 is released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can also include the patch to ship with go1.22, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patching go.mod / go.sum is prone to conflicts, so we'd have to make a new patch specifically for the old release commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are > 100 commits since the last release, confirming my suspicion: quay/clair@v4.7.2...main
Would it make sense to add tag |
a0c6c58
to
c38487b
Compare
rebased and run after #157782 merge |
We should remove
|
Follow-up to * Homebrew#157782 Signed-off-by: Rui Chen <rui@chenrui.dev>
c38487b
to
63bad93
Compare
13-x86_64 and 14-x86_64 are 404ing on the mirror, but it's definitely working:
|
Any idea why would this be happening? This is not specifically related to Go, as this happens earlier, when trying to download the Go source tarball from the mirror. |
Follow-up to
Related:
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?