Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go@1.21 1.21.7 (new formula) #162713

Merged
merged 12 commits into from
Feb 15, 2024
Merged

go@1.21 1.21.7 (new formula) #162713

merged 12 commits into from
Feb 15, 2024

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Feb 14, 2024

Follow-up to

  • go 1.22.0 #157782 ( ⬅️ this has to be merged first, because it removes go@1.21 symlink alias ⚠️ )

Related:


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core legacy Relates to a versioned @ formula automerge-skip `brew pr-automerge` will skip this pull request labels Feb 14, 2024
@chenrui333
Copy link
Member

brew audit go@1.21 --new
brew test --verbose operator-sdk
brew test --verbose tfproviderlint
brew fetch --retry tkey-ssh-agent --build-bottle --force

there are some test failures with operator-sdk and tfproviderlint

@stefanb
Copy link
Member Author

stefanb commented Feb 15, 2024

IMO we should handle the problematic 3 formulae separately from this PR. Should I move them to separate PRs?

@chenrui333
Copy link
Member

IMO we should handle the problematic 3 formulae separately from this PR. Should I move them to separate PRs?

yeah, you can. (I actually already did one)

@@ -20,7 +20,7 @@ class Clair < Formula
sha256 cellar: :any_skip_relocation, x86_64_linux: "bb434c8789c0d0b1fe858eb2573cd97a9c52cf34b04872b03126a10ace8f43b6"
end

depends_on "go" => :build
depends_on "go@1.21" => :build # use "go" again when https://github.com/quay/clair/pull/1942 is released
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also include the patch to ship with go1.22, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patching go.mod / go.sum is prone to conflicts, so we'd have to make a new patch specifically for the old release commit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are > 100 commits since the last release, confirming my suspicion: quay/clair@v4.7.2...main

@stefanb stefanb marked this pull request as ready for review February 15, 2024 07:40
@stefanb
Copy link
Member Author

stefanb commented Feb 15, 2024

Would it make sense to add tag CI-no-fail-fast ?

@bevanjkay bevanjkay added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 15, 2024
@chenrui333 chenrui333 force-pushed the go-1.21.7 branch 2 times, most recently from a0c6c58 to c38487b Compare February 15, 2024 11:18
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Feb 15, 2024
@chenrui333
Copy link
Member

rebased and run after #157782 merge

@chenrui333
Copy link
Member

chenrui333 commented Feb 15, 2024

We should remove kapacitor and trezor-bridge from the list (as they are not buildable from source at this point)


SMillerDev referenced this pull request Feb 15, 2024
@p-linnane
Copy link
Member

13-x86_64 and 14-x86_64 are 404ing on the mirror, but it's definitely working:

╰─ curl -IL https://fossies.org/linux/misc/go1.21.7.src.tar.gz
HTTP/1.1 200 OK

@stefanb
Copy link
Member Author

stefanb commented Feb 15, 2024

Any idea why would this be happening? This is not specifically related to Go, as this happens earlier, when trying to download the Go source tarball from the mirror.

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Feb 15, 2024
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 15, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 15, 2024
Merged via the queue into Homebrew:master with commit fd6d076 Feb 15, 2024
12 checks passed
@stefanb stefanb deleted the go-1.21.7 branch February 15, 2024 20:39
@stefanb stefanb mentioned this pull request Feb 15, 2024
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants