Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python@3.12 python-gdbm@3.12 python-tk@3.12 3.12.0 #149142

Merged
merged 7 commits into from
Oct 4, 2023
Merged

python@3.12 python-gdbm@3.12 python-tk@3.12 3.12.0 #149142

merged 7 commits into from
Oct 4, 2023

Conversation

p-linnane
Copy link
Member

@p-linnane p-linnane commented Oct 2, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core legacy Relates to a versioned @ formula labels Oct 2, 2023
@p-linnane p-linnane added python Python use is a significant feature of the PR or issue and removed legacy Relates to a versioned @ formula labels Oct 2, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 2, 2023
@Bo98
Copy link
Member

Bo98 commented Oct 2, 2023

If we're switching the alias in the same pull request then you'll need to update Python 3.11 to use altinstall. Only one Python formula (the one pointed to by the alias) should have install, the rest should use altinstall.

@p-linnane
Copy link
Member Author

Thanks. I'll update the open python@3.11 PR.

@Bo98
Copy link
Member

Bo98 commented Oct 2, 2023

Ok, will need to be merged at the same time then.

@p-linnane
Copy link
Member Author

Does that make sense? Or would it be bettere to do the alias stuff after the version bumps?

@Bo98
Copy link
Member

Bo98 commented Oct 2, 2023

What you could do is ship Python 3.11 with no changes (except the version bump), ship 3.12 with no alias changes and with altinstall (no link_overwrite etc). That should be trivial to do and is what we did last year and shipped within a day.

Then you can have a PR afterwards that collectively:

  • Swaps 3.11 install -> altinstall, removes link_overwrite etc
  • Swaps 3.12 altinstall -> install, adds link_overwrite etc
  • Updates aliases

There might be dependents that reference python3 rather than python3.11 so will need to watch CI on that one. Might be beneficial to update some multi-Python formulae to add 3.12 first - there's not many of them I don't think.

@p-linnane
Copy link
Member Author

That sounds like a good idea. I've pushed those changes here.

@Bo98
Copy link
Member

Bo98 commented Oct 2, 2023

3.10 has a couple additional "remove symlinks that conflict with the main Python formula" lines that may be relevant here too.

You also want to update the "unversioned symlinks" libexec/bin code to include the 3-suffixed stuff (also see python@3.10.rb), and the caveats to basically match 3.10.

@p-linnane p-linnane added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 2, 2023
@p-linnane
Copy link
Member Author

Think I got all those changes incorporated now.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few:

@Bo98
Copy link
Member

Bo98 commented Oct 2, 2023

(We maybe should probably document the differences somewhere for next time, or make it generic)

@branchvincent
Copy link
Member

I think we also wanted to start marking our python as externally managed: #129943 and https://peps.python.org/pep-0668/

@p-linnane
Copy link
Member Author

@branchvincent Feel free to push to this PR if you have time.

@Bo98
Copy link
Member

Bo98 commented Oct 2, 2023

libedit fix to test (will submit upstream if it works): Bo98/cpython@eb801d8

Co-authored-by: Bo Anderson <mail@boanderson.me>
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
Co-authored-by: Sean Molenaar <smillerdev@me.com>
@cclauss
Copy link
Contributor

cclauss commented Oct 3, 2023

ModuleNotFoundError: No module named 'setuptools'

p-linnane and others added 3 commits October 3, 2023 19:08
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
@p-linnane p-linnane added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 4, 2023
@p-linnane
Copy link
Member Author

Thanks @branchvincent!

@branchvincent
Copy link
Member

Thanks @p-linnane for doing the bulk of the work! Main change was gdbm/tk now need a setuptools resource since it's no longer bundled with python. So as we start migrating all our formulae to 3.12, we'll need similar changes

Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-linnane
Copy link
Member Author

Credit to @Bo98. I just followed his guidance!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 4, 2023
@BrewTestBot BrewTestBot enabled auto-merge October 4, 2023 02:53
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 4, 2023
Merged via the queue into Homebrew:master with commit 93b9a34 Oct 4, 2023
@p-linnane p-linnane deleted the python@3.12-add-formula branch October 4, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants