-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python@3.12 python-gdbm@3.12 python-tk@3.12 3.12.0 #149142
python@3.12 python-gdbm@3.12 python-tk@3.12 3.12.0 #149142
Conversation
If we're switching the alias in the same pull request then you'll need to update Python 3.11 to use |
Thanks. I'll update the open |
Ok, will need to be merged at the same time then. |
Does that make sense? Or would it be bettere to do the alias stuff after the version bumps? |
What you could do is ship Python 3.11 with no changes (except the version bump), ship 3.12 with no alias changes and with Then you can have a PR afterwards that collectively:
There might be dependents that reference |
That sounds like a good idea. I've pushed those changes here. |
3.10 has a couple additional "remove symlinks that conflict with the main Python formula" lines that may be relevant here too. You also want to update the "unversioned symlinks" libexec/bin code to include the |
Think I got all those changes incorporated now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last few:
(We maybe should probably document the differences somewhere for next time, or make it generic) |
I think we also wanted to start marking our python as externally managed: #129943 and https://peps.python.org/pep-0668/ |
@branchvincent Feel free to push to this PR if you have time. |
libedit fix to test (will submit upstream if it works): Bo98/cpython@eb801d8 |
Co-authored-by: Bo Anderson <mail@boanderson.me> Co-authored-by: Branch Vincent <branchevincent@gmail.com> Co-authored-by: Sean Molenaar <smillerdev@me.com>
|
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
Thanks @branchvincent! |
Thanks @p-linnane for doing the bulk of the work! Main change was gdbm/tk now need a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful job @p-linnane @Bo98 @branchvincent!
Credit to @Bo98. I just followed his guidance! |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?