Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autobump: remove docfx (as it needs dotnet@8) #128161

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Apr 12, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

docfx needs dotnet@8 (but it is still in preview status at the moment, https://github.com/dotnet/installer/releases/tag/v8.0.100-preview.3.23178.7), removing it and we can bring it back once we have dotnet@8

  /opt/homebrew/Cellar/dotnet/7.0.100/libexec/sdk/7.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(144,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 8.0.  Either target .NET 7.0 or lower, or use a version of the .NET SDK that supports .NET 8.0. [/private/tmp/docfx-20230411-38464-py7up6/docfx-2.65.2/src/docfx/docfx.csproj::TargetFramework=net8.0]

relates to:

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Apr 12, 2023
@chenrui333 chenrui333 requested review from a team and MikeMcQuaid as code owners April 12, 2023 13:58
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels Apr 12, 2023
@dawidd6 dawidd6 added this pull request to the merge queue Apr 12, 2023
Merged via the queue into Homebrew:master with commit dde5e73 Apr 12, 2023
@chenrui333 chenrui333 deleted the autobump/remove-docfx branch January 22, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants