Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python@3.{10,11}: revision bump for alias migration #123165

Closed
wants to merge 2 commits into from

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

We didn't rev bump in #114154 but I think we should so all users have the same python3

@branchvincent branchvincent added long build Set a long timeout for formula testing CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Feb 14, 2023
@michaelblyons
Copy link

Does the rev-bump need to go through "The tests are failing," "That one pre-dates the change," and so on? It took four months to get the #114154 through. Please don't delay too long before users actually see the benefits.

@branchvincent
Copy link
Member Author

No this should be good to merge after a single CI run, we didn't intend for the other PR to take that long

@branchvincent branchvincent added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 16, 2023
@p-linnane p-linnane removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 16, 2023
@branchvincent
Copy link
Member Author

Forgot the self-hosted label so Linux got halfway through before timing out, but without any failures. Don't think it's worth rerunning

@branchvincent branchvincent added the ready to merge PR can be merged once CI is green label Feb 17, 2023
@SMillerDev
Copy link
Member

Do we have bottles for everything?

@branchvincent
Copy link
Member Author

Yes all bottles were built/uploaded (here's the linux one)

@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@chenrui333
Copy link
Member

Yeah, I can see the bottles for the linux run as well

2 bottles
ls: cannot access 'failed/*.json': No such file or directory
0 failed bottles

@branchvincent branchvincent deleted the python3 branch February 18, 2023 11:24
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants