-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mailhog is not truly building 0.2.0 version #2501
Comments
Usually we use the latest revision of a dependency since Go often just pulls |
I looked into this the other night & fell down a deep, deep rabbithole. It turns out we've added some dependencies as |
@swrobel The specific revisions were locked because with the most recent versions of external dependencies MailHog would not build, at least at the time the formula was created. |
@maijs I was afraid of that. I've filed a related issue with Mailhog about the complicated build process In the interim, how does everyone feel about using the prebuilt binaries that mailhog offers? |
@swrobel I haven't used prebuilt binaries on a Mac, but they do work out-of-box on Ubuntu. |
amd64 build is working great for me on 2 separate macs |
We don't use prebuilt binaries in Homebrew. Could you try and open a pull request? This document should help and I'm happy to walk you through anything else. Thanks! |
Given the problematic upstream build process I'd lean towards either removing from Homebrew completely, accepting the status quo with outdated resources or removing from |
I cannot emphasise enough how reluctant we would be to backport this much from upstream if the existing build wasn't completely broken in several ways. As it happens, it's either this or the boneyard, so let's go with this. Ref: #2931 Ref: #2501 (comment)
Please follow the general troubleshooting steps first:
brew update
and retried your prior step?brew doctor
, fixed as many issues as possible and retried your prior step?sudo chown -R $(whoami) $(brew --prefix)
?You can erase any parts of this template not applicable to your Issue.
Bug reports:
The mailhog formula downloads the correct 0.2.0 version of the archive from github, but then downloading outdated versions of the deps, such as Mailhog, Mailhog-UI and Mailhog-Server.
I would submit a PR to update these, but:
The text was updated successfully, but these errors were encountered: