Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python@3.8 handling to virtualenv_install_with_resources #6858

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

bayandin
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Since we have python@3.8 formula, we need virtualenv_install_with_resources to handle it correctly.
Currently for python@3.8 it uses python2.7 which is not what we want.

Another possible solution is explicitly specifying python3.8 in all formulae during the migration:

-    virtualenv_install_with_resources
+    virtualenv_install_with_resources using: "python3.8"

But I still prefer to change formulae as less as possible.

Ref: Homebrew/homebrew-core#47326

@MikeMcQuaid MikeMcQuaid merged commit 8c0229a into Homebrew:master Dec 19, 2019
@bayandin bayandin deleted the patch-1 branch December 19, 2019 17:40
@lock lock bot added the outdated PR was locked due to age label Jan 18, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants