This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
DynamoDB Streams #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusgrigaitis
suggested changes
Dec 13, 2016
| @@ -0,0 +1,15 @@ | |||
| { | |||
| @@ -67,5 +71,21 @@ module.exports = function createTable(store, data, cb) { | |||
| }) | |||
| }) | |||
| }) | |||
| } | |||
|
|
|||
| function toStreamLabelString(date) { | |||
There was a problem hiding this comment.
Why not take zulu time and remove zulu part?
| @@ -29,7 +31,49 @@ module.exports = function putItem(store, data, cb) { | |||
|
|
|||
| itemDb.put(key, data.Item, function(err) { | |||
| if (err) return cb(err) | |||
| cb(null, returnObj) | |||
|
|
|||
| if (table.LatestStreamArn) { | |||
There was a problem hiding this comment.
This code is (almost) duplicated with delete / put actions
9e94b14 to
3b0fbf3
Compare
Hardcoded AWS region also got removed.
3b0fbf3 to
cb2fb95
Compare
|
Closing in favour of architect#67 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.