Remove unneeded space between double closing angle brackets

The space is unnecessary and clang-format complains about it. See
mixxxdj#4547 (comment).

This patch was created using:

    $ find src \( -name "*.h" -o -name "*.cpp" \) -exec sed -i 's/> >/>>/' {} \;

src/control/controlmodel.h

@@ -54,6 +54,6 @@ class ControlModel final : public QAbstractTableModel {
         ControlProxy* pControl;
     };
 
-    QVector<QHash<int, QVariant> > m_headerInfo;
+    QVector<QHash<int, QVariant>> m_headerInfo;
     QList<ControlInfo> m_controls;
 };

src/controllers/controllermappingtablemodel.h

@@ -37,6 +37,6 @@ class ControllerMappingTableModel : public QAbstractTableModel {
     // m_pHidMapping points to the HID mapping.
     virtual void onMappingLoaded() = 0;
 
-    QVector<QHash<int, QVariant> > m_headerInfo;
+    QVector<QHash<int, QVariant>> m_headerInfo;
     std::shared_ptr<LegacyMidiControllerMapping> m_pMidiMapping;
 };

src/controllers/dlgcontrollerlearning.h

@@ -82,6 +82,6 @@ class DlgControllerLearning : public QDialog,
     bool m_messagesLearned;
     QTimer m_firstMessageTimer;
     QTimer m_lastMessageTimer;
-    QList<QPair<MidiKey, unsigned char> > m_messages;
+    QList<QPair<MidiKey, unsigned char>> m_messages;
     MidiInputMappings m_mappings;
 };

src/controllers/learningutils.cpp

@@ -49,7 +49,7 @@ struct MessageStats {
 // static
 MidiInputMappings LearningUtils::guessMidiInputMappings(
         const ConfigKey& control,
-        const QList<QPair<MidiKey, unsigned char> >& messages) {
+        const QList<QPair<MidiKey, unsigned char>>& messages) {
     QMap<unsigned char, MessageStats> stats_by_control;
     MessageStats stats;
 

src/controllers/learningutils.h

@@ -9,5 +9,5 @@ class LearningUtils {
   public:
     static MidiInputMappings guessMidiInputMappings(
         const ConfigKey& control,
-        const QList<QPair<MidiKey, unsigned char> >& messages);
+        const QList<QPair<MidiKey, unsigned char>>& messages);
 };

src/controllers/legacycontrollermapping.h

@@ -175,7 +175,7 @@ class LegacyControllerMapping {
     virtual bool isMappable() const = 0;
 
     // Optional list of controller device match details
-    QList<QHash<QString, QString> > m_productMatches;
+    QList<QHash<QString, QString>> m_productMatches;
 
   private:
     bool m_bDirty;

src/controllers/midi/midicontroller.h

@@ -91,7 +91,7 @@ class MidiController : public Controller {
     QList<MidiOutputHandler*> m_outputs;
     std::shared_ptr<LegacyMidiControllerMapping> m_pMapping;
     SoftTakeoverCtrl m_st;
-    QList<QPair<MidiInputMapping, unsigned char> > m_fourteen_bit_queued_mappings;
+    QList<QPair<MidiInputMapping, unsigned char>> m_fourteen_bit_queued_mappings;
 
     // So it can access sendShortMsg()
     friend class MidiOutputHandler;

src/effects/backends/builtin/parametriceqeffect.h

@@ -29,7 +29,7 @@ class ParametricEQEffectGroupState final : public EffectState {
 
     // These containers are only appended in the constructor which is called on
     // the main thread, so there is no risk of allocation in the audio thread.
-    std::vector<std::unique_ptr<EngineFilterBiquad1Peaking> > m_bands;
+    std::vector<std::unique_ptr<EngineFilterBiquad1Peaking>> m_bands;
     QList<double> m_oldGain;
     QList<double> m_oldCenter;
     QList<double> m_oldQ;

src/effects/backends/effectmanifestparameter.h

@@ -235,7 +235,7 @@ class EffectManifestParameter {
     void appendStep(const QPair<QString, double>& step) {
         m_steps.append(step);
     }
-    const QList<QPair<QString, double> >& getSteps() const {
+    const QList<QPair<QString, double>>& getSteps() const {
         return m_steps;
     }
 
@@ -270,7 +270,7 @@ class EffectManifestParameter {
     /// effect parameters
     /// Each pair has the following form:
     /// name - value
-    QList<QPair<QString, double> > m_steps;
+    QList<QPair<QString, double>> m_steps;
 };
 
 QDebug operator<<(QDebug dbg, const EffectManifestParameter& parameter);

src/library/basesqltablemodel.h

@@ -152,7 +152,7 @@ class BaseSqlTableModel : public BaseTrackTableModel {
     TrackId2Rows m_trackIdToRows;
     QString m_currentSearch;
     QString m_currentSearchFilter;
-    QVector<QHash<int, QVariant> > m_headerInfo;
+    QVector<QHash<int, QVariant>> m_headerInfo;
     QString m_trackSourceOrderBy;
 
     DISALLOW_COPY_AND_ASSIGN(BaseSqlTableModel);

src/library/basetrackcache.h

@@ -147,7 +147,7 @@ class BaseTrackCache : public QObject {
 
     bool m_bIndexBuilt;
     bool m_bIsCaching;
-    QHash<TrackId, QVector<QVariant> > m_trackInfo;
+    QHash<TrackId, QVector<QVariant>> m_trackInfo;
     QSqlDatabase m_database;
 
     DISALLOW_COPY_AND_ASSIGN(BaseTrackCache);

src/library/browse/browsetablemodel.cpp

@@ -159,8 +159,8 @@ BrowseTableModel::BrowseTableModel(QObject* parent,
 
     setHorizontalHeaderLabels(headerLabels);
     // register the QList<T> as a metatype since we use QueuedConnection below
-    qRegisterMetaType<QList<QList<QStandardItem*> > >(
-            "QList< QList<QStandardItem*> >");
+    qRegisterMetaType<QList<QList<QStandardItem*>> >(
+            "QList< QList<QStandardItem*>>");
     qRegisterMetaType<BrowseTableModel*>("BrowseTableModel*");
 
     m_pBrowseThread = BrowseThread::getInstanceRef();
@@ -354,7 +354,7 @@ void BrowseTableModel::slotClear(BrowseTableModel* caller_object) {
     }
 }
 
-void BrowseTableModel::slotInsert(const QList<QList<QStandardItem*> >& rows,
+void BrowseTableModel::slotInsert(const QList<QList<QStandardItem*>>& rows,
         BrowseTableModel* caller_object) {
     // There exists more than one BrowseTableModel in Mixxx We only want to
     // receive items here, this object has 'ordered' by the BrowserThread

src/library/browse/browsetablemodel.h

@@ -95,7 +95,7 @@ class BrowseTableModel final : public QStandardItemModel, public virtual TrackMo
 
   public slots:
     void slotClear(BrowseTableModel*);
-    void slotInsert(const QList< QList<QStandardItem*> >&, BrowseTableModel*);
+    void slotInsert(const QList< QList<QStandardItem*>>&, BrowseTableModel*);
     void trackChanged(const QString& group, TrackPointer pNewTrack, TrackPointer pOldTrack);
 
   private:

src/library/browse/browsethread.cpp

@@ -134,7 +134,7 @@ void BrowseThread::populateModel() {
     // see signal/slot connection in BrowseTableModel
     emit clearModel(thisModelObserver);
 
-    QList< QList<QStandardItem*> > rows;
+    QList< QList<QStandardItem*>> rows;
 
     int row = 0;
     // Iterate over the files

src/library/browse/browsethread.h

@@ -35,7 +35,7 @@ class BrowseThread : public QThread {
     static BrowseThreadPointer getInstanceRef();
 
   signals:
-    void rowsAppended(const QList< QList<QStandardItem*> >&, BrowseTableModel*);
+    void rowsAppended(const QList< QList<QStandardItem*>>&, BrowseTableModel*);
     void clearModel(BrowseTableModel*);
 
   private:

src/library/parsercsv.cpp

@@ -36,7 +36,7 @@ QList<QString> ParserCsv::parse(const QString& sFilename) {
     if (file.open(QIODevice::ReadOnly)) {
         QByteArray ba = file.readAll();
 
-        QList<QList<QString> > tokens = tokenize(ba, ',');
+        QList<QList<QString>> tokens = tokenize(ba, ',');
 
         // detect Location column
         int loc_coll = 0x7fffffff;
@@ -76,8 +76,8 @@ QList<QString> ParserCsv::parse(const QString& sFilename) {
 
 // Code was posted at http://www.qtcentre.org/threads/35511-Parsing-CSV-data
 // by "adzajac" and adapted to use QT Classes
-QList<QList<QString> > ParserCsv::tokenize(const QByteArray& str, char delimiter) {
-    QList<QList<QString> > tokens;
+QList<QList<QString>> ParserCsv::tokenize(const QByteArray& str, char delimiter) {
+    QList<QList<QString>> tokens;
 
     unsigned int row = 0;
     bool quotes = false;

src/library/parsercsv.h

@@ -34,7 +34,7 @@ class ParserCsv : public Parser
     static bool writeReadableTextFile(const QString &file, BaseSqlTableModel* pPlaylistTableModel,  bool writeTimestamp);
 private:
     /**Reads a line from the file and returns filepath if a valid file**/
-    QList<QList<QString> > tokenize(const QByteArray& str, char delimiter);
+    QList<QList<QString>> tokenize(const QByteArray& str, char delimiter);
 
 
 };

src/preferences/upgrade.cpp

@@ -286,12 +286,12 @@ UserSettingsPointer Upgrade::versionUpgrade(const QString& settingsPath) {
         QDir newOSXDir(OSXLocation190);
         newOSXDir.mkpath(OSXLocation190);
 
-        QList<QPair<QString, QString> > dirsToMove;
+        QList<QPair<QString, QString>> dirsToMove;
         dirsToMove.push_back(QPair<QString, QString>(OSXLocation180, OSXLocation190));
         dirsToMove.push_back(QPair<QString, QString>(OSXLocation180 + "/midi", OSXLocation190 + "midi"));
         dirsToMove.push_back(QPair<QString, QString>(OSXLocation180 + "/presets", OSXLocation190 + "presets"));
 
-        QListIterator<QPair<QString, QString> > dirIt(dirsToMove);
+        QListIterator<QPair<QString, QString>> dirIt(dirsToMove);
         QPair<QString, QString> curPair;
         while (dirIt.hasNext())
         {

src/soundio/sounddevicenetwork.cpp

@@ -74,11 +74,11 @@ SoundDeviceError SoundDeviceNetwork::open(bool isClkRefDevice, int syncBuffers)
     // clock reference device callback
     // This is what should work best.
     if (m_iNumOutputChannels) {
-        m_outputFifo = std::make_unique<FIFO<CSAMPLE> >(
+        m_outputFifo = std::make_unique<FIFO<CSAMPLE>>(
                 m_iNumOutputChannels * m_framesPerBuffer * 2);
     }
     if (m_iNumInputChannels) {
-        m_inputFifo = std::make_unique<FIFO<CSAMPLE> >(
+        m_inputFifo = std::make_unique<FIFO<CSAMPLE>>(
                 m_iNumInputChannels * m_framesPerBuffer * 2);
     }
 

src/soundio/sounddevicenetwork.h

@@ -55,8 +55,8 @@ class SoundDeviceNetwork : public SoundDevice {
     void workerWriteSilence(NetworkOutputStreamWorkerPtr pWorker, int frames);
 
     QSharedPointer<EngineNetworkStream> m_pNetworkStream;
-    std::unique_ptr<FIFO<CSAMPLE> > m_outputFifo;
-    std::unique_ptr<FIFO<CSAMPLE> > m_inputFifo;
+    std::unique_ptr<FIFO<CSAMPLE>> m_outputFifo;
+    std::unique_ptr<FIFO<CSAMPLE>> m_inputFifo;
     bool m_inputDrift;
 
     std::unique_ptr<ControlProxy> m_pMasterAudioLatencyUsage;

src/test/learningutilstest.cpp

@@ -36,7 +36,7 @@ class LearningUtilsTest : public MixxxTest {
         return false;
     }
 
-    QList<QPair<MidiKey, unsigned char> > m_messages;
+    QList<QPair<MidiKey, unsigned char>> m_messages;
 };
 
 TEST_F(LearningUtilsTest, NoteOnButton) {

src/track/keys.h

@@ -8,7 +8,7 @@
 
 #define KEY_MAP_VERSION "KeyMap-1.0"
 
-typedef QList<QPair<mixxx::track::io::key::ChromaticKey, double> > KeyChangeList;
+typedef QList<QPair<mixxx::track::io::key::ChromaticKey, double>> KeyChangeList;
 
 class KeyFactory;
 

src/util/lcs.h

@@ -10,7 +10,7 @@ inline QString LCS(const QString& a, const QString& b) {
     const int rows = m + 1;
     const int cols = n + 1;
 
-    QVector<QVector<int> > M(rows);
+    QVector<QVector<int>> M(rows);
     int longest = 0;
     int longest_loc = 0;
 

src/util/messagepipe.h

@@ -77,18 +77,18 @@ class TwoWayMessagePipe {
                  MessagePipe<ReceiverMessageType, SenderMessageType>*> makeTwoWayMessagePipe(
                      int sender_fifo_size,
                      int receiver_fifo_size) {
-        QSharedPointer<TwoWayMessagePipe<SenderMessageType, ReceiverMessageType> > pipe(
+        QSharedPointer<TwoWayMessagePipe<SenderMessageType, ReceiverMessageType>> pipe(
             new TwoWayMessagePipe<SenderMessageType, ReceiverMessageType>(
                 sender_fifo_size, receiver_fifo_size));
 
         return QPair<MessagePipe<SenderMessageType, ReceiverMessageType>*,
                      MessagePipe<ReceiverMessageType, SenderMessageType>*>(
                          new MessagePipe<SenderMessageType, ReceiverMessageType>(
                              pipe->m_receiver_messages, pipe->m_sender_messages,
-                             new ReferenceHolder<TwoWayMessagePipe<SenderMessageType, ReceiverMessageType> >(pipe)),
+                             new ReferenceHolder<TwoWayMessagePipe<SenderMessageType, ReceiverMessageType>>(pipe)),
                          new MessagePipe<ReceiverMessageType, SenderMessageType>(
                              pipe->m_sender_messages, pipe->m_receiver_messages,
-                             new ReferenceHolder<TwoWayMessagePipe<SenderMessageType, ReceiverMessageType> >(pipe)));
+                             new ReferenceHolder<TwoWayMessagePipe<SenderMessageType, ReceiverMessageType>>(pipe)));
     }
 
   private:

src/util/statmodel.h

@@ -45,7 +45,7 @@ class StatModel final : public QAbstractTableModel {
     void statUpdated(const Stat& stat);
 
   private:
-    QVector<QHash<int, QVariant> > m_headerInfo;
+    QVector<QHash<int, QVariant>> m_headerInfo;
     QList<Stat> m_stats;
     QHash<QString, int> m_statNameToRow;
 };

src/waveform/visualplayposition.cpp

@@ -18,7 +18,7 @@ constexpr int kMicrosPerMillis = 1000; // 1 ms contains 1000 µs
 
 
 //static
-QMap<QString, QWeakPointer<VisualPlayPosition> > VisualPlayPosition::m_listVisualPlayPosition;
+QMap<QString, QWeakPointer<VisualPlayPosition>> VisualPlayPosition::m_listVisualPlayPosition;
 PerformanceTimer VisualPlayPosition::m_timeInfoTime;
 double VisualPlayPosition::m_dCallbackEntryToDacSecs = 0;
 

src/waveform/visualplayposition.h

@@ -73,7 +73,7 @@ class VisualPlayPosition : public QObject {
     bool m_valid;
     QString m_key;
 
-    static QMap<QString, QWeakPointer<VisualPlayPosition> > m_listVisualPlayPosition;
+    static QMap<QString, QWeakPointer<VisualPlayPosition>> m_listVisualPlayPosition;
     // Time info from the Sound device, updated just after audio callback is called
     static double m_dCallbackEntryToDacSecs;
     // Time stamp for m_timeInfo in main CPU time

src/waveform/visualsmanager.h

@@ -80,6 +80,6 @@ class VisualsManager {
         }
     }
   private:
-    std::vector<std::unique_ptr<DeckVisuals> > m_deckVisuals;
+    std::vector<std::unique_ptr<DeckVisuals>> m_deckVisuals;
     PerformanceTimer m_cpuTimer;
 };

src/waveform/vsyncthread.cpp

@@ -131,7 +131,7 @@ void VSyncThread::vsyncSlotFinished() {
     m_semaVsyncSlot.release();
 }
 
-void VSyncThread::getAvailableVSyncTypes(QList<QPair<int, QString > >* pList) {
+void VSyncThread::getAvailableVSyncTypes(QList<QPair<int, QString >>* pList) {
     for (int i = (int)VSyncThread::ST_TIMER; i < (int)VSyncThread::ST_COUNT; i++) {
         //if (isAvailable(type))  // TODO
         {

src/waveform/vsyncthread.h

@@ -34,7 +34,7 @@ class VSyncThread : public QThread {
     void setSwapWait(int sw);
     int fromTimerToNextSyncMicros(const PerformanceTimer& timer);
     void vsyncSlotFinished();
-    void getAvailableVSyncTypes(QList<QPair<int, QString > >* list);
+    void getAvailableVSyncTypes(QList<QPair<int, QString >>* list);
     void setupSync(QGLWidget* glw, int index);
     void waitUntilSwap(QGLWidget* glw);
 

src/waveform/waveformwidgetfactory.cpp

@@ -1042,7 +1042,7 @@ void WaveformWidgetFactory::startVSync(GuiTick* pGuiTick, VisualsManager* pVisua
     m_vsyncThread->start(QThread::NormalPriority);
 }
 
-void WaveformWidgetFactory::getAvailableVSyncTypes(QList<QPair<int, QString > >* pList) {
+void WaveformWidgetFactory::getAvailableVSyncTypes(QList<QPair<int, QString >>* pList) {
     m_vsyncThread->getAvailableVSyncTypes(pList);
 }
 

src/waveform/waveformwidgetfactory.h

@@ -119,7 +119,7 @@ class WaveformWidgetFactory : public QObject, public Singleton<WaveformWidgetFac
     int isOverviewNormalized() const { return m_overviewNormalized;}
 
     const QVector<WaveformWidgetAbstractHandle> getAvailableTypes() const { return m_waveformWidgetHandles;}
-    void getAvailableVSyncTypes(QList<QPair<int, QString > >* list);
+    void getAvailableVSyncTypes(QList<QPair<int, QString >>* list);
     void destroyWidgets();
 
     void addTimerListener(WVuMeter* pWidget);

src/widget/weffectpushbutton.cpp

@@ -109,7 +109,7 @@ void WEffectPushButton::parameterUpdated() {
 
     m_pButtonMenu->clear();
     EffectManifestParameterPointer pManifest = m_pEffectParameterSlot->getManifest();
-    QList<QPair<QString, double> > options;
+    QList<QPair<QString, double>> options;
     if (pManifest) {
         options = pManifest->getSteps();
     }

src/widget/wimagestore.cpp

@@ -9,7 +9,7 @@
 
 
 // static
-QHash<QString, std::weak_ptr<QImage> > WImageStore::m_dictionary;
+QHash<QString, std::weak_ptr<QImage>> WImageStore::m_dictionary;
 QSharedPointer<ImgSource> WImageStore::m_loader
         = QSharedPointer<ImgSource>(new ImgLoader());
 
@@ -31,7 +31,7 @@ std::shared_ptr<QImage> WImageStore::getImage(const PixmapSource& source, double
     // Search for Image in list
     QString key = source.getId() + QString::number(scaleFactor);
 
-    QHash<QString, std::weak_ptr<QImage> >::iterator it = m_dictionary.find(key);
+    QHash<QString, std::weak_ptr<QImage>>::iterator it = m_dictionary.find(key);
     if (it != m_dictionary.end()) {
         //qDebug() << "WImageStore returning cached Image for:" << source.getPath();
         return it.value().lock();
@@ -88,7 +88,7 @@ QImage* WImageStore::getImageNoCache(const PixmapSource& source, double scaleFac
 
 // static
 void WImageStore::deleteImage(QImage* p) {
-    QMutableHashIterator<QString, std::weak_ptr<QImage> >it(m_dictionary);
+    QMutableHashIterator<QString, std::weak_ptr<QImage>>it(m_dictionary);
     while (it.hasNext()) {
         if(it.next().value().expired()) {
             it.remove();

src/widget/wimagestore.h

@@ -24,6 +24,6 @@ class WImageStore {
     static void deleteImage(QImage* p);
 
     // Dictionary of Images already instantiated
-    static QHash<QString, std::weak_ptr<QImage> > m_dictionary;
+    static QHash<QString, std::weak_ptr<QImage>> m_dictionary;
     static QSharedPointer<ImgSource> m_loader;
 };