Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adjust width when items deleted #431

Closed
chip33 opened this issue Aug 2, 2022 · 4 comments
Closed

[Feature] Adjust width when items deleted #431

chip33 opened this issue Aug 2, 2022 · 4 comments
Assignees
Labels
Milestone

Comments

@chip33
Copy link
Contributor

chip33 commented Aug 2, 2022

If items are removed from the root menu the menu height now refreshes automatically to reflect the change but the menu width stays wider until it is restarted manually.

Screenshot 2022-08-03 074515

Screenshot 2022-08-03 080429

@chip33 chip33 changed the title [BUG] Menu width not refreshing on item removal [Feature] Adjust width when items deleted or added Aug 2, 2022
@chip33 chip33 changed the title [Feature] Adjust width when items deleted or added [Feature] Adjust width when items deleted Aug 2, 2022
@chip33 chip33 changed the title [Feature] Adjust width when items deleted [Feature] Adjust width when items deleted or added Aug 2, 2022
@Hofknecht
Copy link
Owner

Hofknecht commented Aug 3, 2022

@chip33
Thank you for the feedback!
we are happy about every point you find. This way we know what is more important. Thank you for the constant testing!
we will have a look soon

@Hofknecht Hofknecht self-assigned this Aug 3, 2022
@Hofknecht Hofknecht added this to the 1.4 milestone Aug 3, 2022
@Hofknecht
Copy link
Owner

@chip33
we looked at it. So it worked for us The width is adjusted when creating and deleting.

We have a guess as to what it could be.
was the menu so wide before the file was created or was it really so wide when it was created?
Did you show additional folders for search? If yes, then type into search * (asterisk) to see all items. Then scroll through all the items to see if there is a second item that is very long.
We shouldn't adjust the width when searching, so for all items that can be found by searching, the maximum width of the items will be calculated.

Otherwise we need a hint on how you did it : )

@chip33
Copy link
Contributor Author

chip33 commented Aug 6, 2022

@Hofknecht
Ah yes, this only occurs when the Search bar is hidden!
When the Search bar is shown the width does resize automatically.
Screenshot 2022-08-06 164358

If you hide the Search bar then deleting a long file "check_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.txt" from the root directory results in the following behaviour until STM is restarted manually.
Screenshot 2022-08-06 172943

Screenshot 2022-08-06 172257

@chip33 chip33 changed the title [Feature] Adjust width when items deleted or added [Feature] Adjust width when items deleted Aug 6, 2022
@Hofknecht
Copy link
Owner

@chip33
Thanks for pointing that out, now we've been able to reproduce it and it's fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants