Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Settings dialog doesn't show all elements #217

Closed
kristofzerbe opened this issue Oct 11, 2021 · 7 comments
Closed

[BUG] Settings dialog doesn't show all elements #217

kristofzerbe opened this issue Oct 11, 2021 · 7 comments

Comments

@kristofzerbe
Copy link
Contributor

A couple of days ago I made a pull request with the new feature "Open Folder" (#206) in settings and was fiddling a bit around with the size of the settings dialog, because the content doesn't fit.

In the new version (10.0.21.0) I see that the new button is implemented in code, but it doesn't appear in the dialog and some of the elements at the bottom of the dialog are out of sight.

systraymenu-settings

Interesting is the preview of the dialog in VS:

systraymenu-preview

The new button "Open Folder" is completely out of sight and tableLayoutPanelChangeFolder as far to wide. I didn't get the problem solved. Is the button pushing its panel to its size or is the panel too wide? It is not possible to change the Size values of the panel. I guess it is the panel, because its Anchor is set to Left, Right and not to Top, Left.

In general it is a problem with Windows Forms dealing with different scalings under Windows 10. When using my full resolution everthing is way too small, but the settings dialog has all elements.

  • OS: Windows 10 Pro, Version 10.0.19042 Build 19042
  • Resolution: 3840 x 2160
  • Scaling: 200%
  • Version: 10.0.21.0
@Hofknecht
Copy link
Owner

@kristofzerbe
Thank you for reporting the issue!

i assume/hope that is probably only a local change in designer in your cloned repository, as is looks normal at several devices on which i tested.

in your PR there were a lot of changes in the designer, which i reverted after, so i assume your visual studio version is re-adjusting/changing controls when you open the form over visual studio. Therefore maybe update visual studio to latest version.

can you try to download latest version, compiled here to compare it:
https://github.com/Hofknecht/SystemTrayMenu/releases/tag/v1.0.21.0

here a screenshot how it looks like in windows dpi size 100%
2021-10-11 17_17_56-Window

2021-10-11 17_18_57-Window

@kristofzerbe
Copy link
Contributor Author

The first two screenshots are not from builded source code, but from the downloaded release assemblies!

@Hofknecht
Copy link
Owner

thank you, now i can reproduce at 200% dpi size

@kristofzerbe
Copy link
Contributor Author

To see the effect, upscale your display in Windows to more than 100%. Interestingly not all panels have this problem.

@Hofknecht
Copy link
Owner

@kristofzerbe

  1. (removed ancor and set dockstyle fill instead)
  2. the textboxPath has style none, that's why its ignoring the aware dpi size and leads to tablelayout getting bigger ... and the button moved to the right side, therfore i set max widh for it
  3. increased height

maybe you can pull latest commit 1.0.21.1 and check if now button appearing and if height is ok
reopen this issue if nok

Thank you!

@kristofzerbe
Copy link
Contributor Author

kristofzerbe commented Oct 11, 2021

Thanks for the fix regarding the button.

The second problem, that the controls at the very bottom are not or just half visible still exists, when scaling up to 225% or higher. I assume is has to do with the lack of AutoSizeMode of tabControl.

(Can't reopen the issue)

@Hofknecht
Copy link
Owner

is now fixed also for 225% in #226 version 1.0.24.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants