-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Add dependency on vision-camera-code-scanner - Only activate camera when screen is focused - FrameProcessor runs once per second since the docs state: > A value of `1` indicates that the frame processor gets executed once per second, perfect for code scanning. - But consider increasing to 5 in the future since the docs also state: > For a QR Code Scanner, 5 FPS (200ms) might suffice - Known issues: Lines 23-25 of QRCamera.tsx sometimes cause the following error when navigating back from JoinOrg: ``` ERROR Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function. in QRCamera (at CameraControl.tsx:19) ```
- Loading branch information
Showing
5 changed files
with
135 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8a7dc5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit broke
npm run ios
because vision-camera-code-scanner doesn't support M1 macs yet. As a result, I needed to enable rosetta as suggested by this issue comment. I'm subscribed to that issue. So hopefully I can disable rosetta whenever vision-camera-code-scanner works for M1.b8a7dc5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^That only fixed building in Xcode. In order to fix
npm run ios
, I also needed to enable rosetta for Terminal