Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop transferring #1

Closed
wants to merge 3 commits into from
Closed

Drop transferring #1

wants to merge 3 commits into from

Conversation

angelsl
Copy link

@angelsl angelsl commented Dec 13, 2010

Drop transferring is a better alternative to MineToChest (which I tried to merge with LWC but was too unsuitable as items ended up being duped). I would release this as a separate plugin but I wanted to maintain LWC compatibility so I ended up merging my idea with LWC.

I doubt that this will get accepted (it's out of LWC's scope) but it's worth a shot.

If it gets denied, I'll release it separately with full credits to you.

Thanks.

@Hidendra
Copy link
Owner

I don't see a problem with the idea. LWC containing features like this would certainly increase its usefulness past being "protection". I thought of extending it to zones, too, but that would first require cleaning everything up and making the code not so messy (that'll happen with Notch's API).

Anywho, I digress.. If you could have it instead use the modes memory table instead of creating another (since it's not being used a whole lot right now), and of course adding a "data" column (mode=droptransfer,data=chestID perhaps). If you don't have time/whatever, I can do that if you wish.

After that I would gladly pull it. I also noticed the is(Not)InPersistentMode, totally missed that one! :3

@angelsl
Copy link
Author

angelsl commented Dec 13, 2010

Alright. I'll do it tomorrow morning. (it's 1AM now)

Thanks a lot. I'll create a new pull request once it's done (since I can't seem to modify existing ones).

@Hidendra
Copy link
Owner

No problem. 1pm here :D (Australian?)

Looking forward to it.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants