Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naive tab sync lock #4

Closed
wants to merge 1 commit into from
Closed

Conversation

HiDeoo
Copy link
Owner

@HiDeoo HiDeoo commented Dec 14, 2023

No description provided.

@TheOtterlord
Copy link

Bringing conversation over here. Looking at this rec, it only affects some elements. Here, the icon & heading are the two things to move. Above this, the "next steps" section and content inside the frontmatter example code snippet also shift.

Screencast from 2023-12-15 11-04-57.webm

@HiDeoo
Copy link
Owner Author

HiDeoo commented Dec 15, 2023

Yeah, this is also exactly what I can see in my tests.

I tweaked a bit the code yesterday evening to bring subpixel precision to the calculation as HTMLElement.offsetTop returns a long typed value (i.e integer) but it looks like that even with the more precise calculation, the result is still the same when passed down to window.scrollTo(). I'll try a little bit more on that idea for sanity check but I'm not super confident that the proper solution is in that direction.

@HiDeoo HiDeoo closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants