Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added_support_for_user_resource #102

Merged
merged 7 commits into from
May 4, 2021
Merged

added_support_for_user_resource #102

merged 7 commits into from
May 4, 2021

Conversation

SHANDCRUZ
Copy link
Contributor

Description

Added support for User Resource

Issues Resolved

[List any issues this PR will resolve. e.g., Fixes #1]

Check List

  • New functionality includes sanity testing.
    • All sanity tests pass. ($ ansible-test sanity).
    • All unit tests pass.
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).

@SHANDCRUZ SHANDCRUZ requested review from VenkateshRavula, yuvirani, AsisBagga and nabhajit-ray and removed request for VenkateshRavula May 3, 2021 10:42
AsisBagga
AsisBagga approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@AsisBagga AsisBagga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SHANDCRUZ SHANDCRUZ merged commit a50b92c into master May 4, 2021
@SHANDCRUZ SHANDCRUZ deleted the user-resource branch May 4, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvirani yuvirani yuvirani approved these changes

@AsisBagga AsisBagga AsisBagga approved these changes

@VenkateshRavula VenkateshRavula Awaiting requested review from VenkateshRavula

@nabhajit-ray nabhajit-ray Awaiting requested review from nabhajit-ray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SHANDCRUZ @yuvirani @AsisBagga