Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gog setup regression #3993

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: gog setup regression #3993

merged 1 commit into from
Sep 10, 2024

Conversation

imLinguin
Copy link
Member

Make sure we use native paths for .exe and workingDirectory

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Sep 3, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team September 3, 2024 14:59
@arielj
Copy link
Collaborator

arielj commented Sep 8, 2024

what was the issue? how can I test the problem in main and this fixing it?

@imLinguin
Copy link
Member Author

The Witcher setup didn't complete. Due to the paths being from windows env

flavioislima
flavioislima approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imLinguin imLinguin merged commit 8e63750 into Heroic-Games-Launcher:main Sep 10, 2024
8 of 9 checks passed
@imLinguin imLinguin deleted the fix/gog-setup-regression branch September 10, 2024 15:21
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imLinguin @arielj @flavioislima