Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Use upstream Winetricks on macOS #3978

Merged
merged 1 commit into from
Aug 25, 2024
Merged

[Fix] Use upstream Winetricks on macOS #3978

merged 1 commit into from
Aug 25, 2024

Conversation

CommandMC
Copy link
Collaborator

Closes #3413

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 24, 2024
@CommandMC CommandMC requested a review from a team August 24, 2024 19:46
@CommandMC CommandMC self-assigned this Aug 24, 2024
@CommandMC CommandMC requested review from arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team August 24, 2024 19:46
@imLinguin imLinguin merged commit 0e90f17 into main Aug 25, 2024
9 checks passed
@imLinguin imLinguin deleted the fix/winetricks-mac branch August 25, 2024 10:50
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@arielj arielj arielj approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use upstream winetricks on macOS
4 participants
@CommandMC @arielj @Etaash-mathamsetty @imLinguin