Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech] Fix some of the smaller ESLint warnings #3958

Merged
merged 4 commits into from
Aug 22, 2024
Merged

[Tech] Fix some of the smaller ESLint warnings #3958

merged 4 commits into from
Aug 22, 2024

Conversation

CommandMC
Copy link
Collaborator

ESLint auto-fixes some of these problems, so in the interest of not making everyone not include these in their PRs (since it's most likely changing something unrelated), I figured I'd make a dedicated PR for them.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 16, 2024
@CommandMC CommandMC requested a review from a team August 16, 2024 13:23
@CommandMC CommandMC self-assigned this Aug 16, 2024
@CommandMC CommandMC requested review from arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team August 16, 2024 13:23
arielj
arielj approved these changes Aug 17, 2024
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I added some comments but nothing crazy or blocker

src/backend/utils/systeminfo/heroicVersion.ts Outdated Show resolved Hide resolved
src/frontend/screens/Settings/components/Tools/index.tsx Show resolved Hide resolved
@CommandMC CommandMC merged commit dbe780d into main Aug 22, 2024
9 checks passed
@CommandMC CommandMC deleted the tech/fix-eslint branch August 22, 2024 15:19
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arielj arielj arielj approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CommandMC @arielj