Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DIST] don't include build-id files in rpm #3951

Merged
merged 1 commit into from
Aug 25, 2024
Merged

[DIST] don't include build-id files in rpm #3951

merged 1 commit into from
Aug 25, 2024

Conversation

imLinguin
Copy link
Member

Closes #3950

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 13, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team August 13, 2024 12:45
@ryzendew
Copy link

could you add an RPM to test this please i could not find one in actions

@imLinguin
Copy link
Member Author

The best bet for you would be to build the branch yourself.

  1. Clone the repo
  2. Install dependencies pnpm install
  3. Download helper binaries pnpm download-helper-binaries
  4. Run rpm build pnpm dist:linux rpm

CommandMC
CommandMC approved these changes Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't run a rpm-based distro, but I can confirm that the relevant folder is no longer in the package file with this PR

@imLinguin imLinguin merged commit a579cb4 into main Aug 25, 2024
9 checks passed
@imLinguin imLinguin deleted the fix/rpm branch August 25, 2024 10:50
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CommandMC CommandMC CommandMC approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heroic can't install on Fedora (.rpm file), caused by conflicting files
3 participants
@imLinguin @ryzendew @CommandMC