Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend birthdate #59

Merged
merged 1 commit into from
May 12, 2024
Merged

extend birthdate #59

merged 1 commit into from
May 12, 2024

Conversation

olsonpm
Copy link

@olsonpm olsonpm commented Dec 24, 2020

No description provided.

guilherme-gm
guilherme-gm approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@guilherme-gm guilherme-gm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I understand the need to override the default "Backward Years" config for this specific case, as players older than 30 years (default) wouldn't be able to input a proper birth date, but for most inputs people probably don't need 30+ years

@olsonpm
Copy link
Author

olsonpm commented May 11, 2024

sure, i mean this was an issue i ran into otherwise i wouldn't have raised a pr

@guilherme-gm guilherme-gm merged commit e1d7896 into HerculesWS:master May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilherme-gm guilherme-gm guilherme-gm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olsonpm @guilherme-gm