Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MLFSIterator, add tests for it #138

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Fix MLFSIterator, add tests for it #138

merged 2 commits into from
Mar 26, 2025

Conversation

THinnerichs
Copy link
Member

@THinnerichs THinnerichs commented Feb 24, 2025

Also:

  • fixed enumeration order for DFS
  • I added tests for DFS because there were none previously.

MLFSIterator requires Herb-AI/HerbGrammar.jl#104 to work.

@THinnerichs THinnerichs requested a review from ReubenJ February 24, 2025 11:40
@THinnerichs THinnerichs self-assigned this Feb 24, 2025
@THinnerichs
Copy link
Member Author

image

Iteration is quite slow for now.

Verified

This commit was signed with the committer’s verified signature.
ReubenJ Reuben Gardos Reid
Copy link
Member

@ReubenJ ReubenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the top-down iterator! Once we update the docstring, I think these changes are looking good 👍

@ReubenJ
Copy link
Member

ReubenJ commented Feb 25, 2025

Iteration is quite slow for now.

Is this slower as a result of this PR?

@THinnerichs
Copy link
Member Author

is this slower as a rsult of this PR?

The previous was written before Bart, and thus didn't account for uniform trees, and is thus wrong.
I updated the probability calculation, reducing enumeration time to 14.5 seconds in the case above.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.95%. Comparing base (7af0f7e) to head (f54e32a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   72.94%   73.95%   +1.01%     
==========================================
  Files          19       19              
  Lines         669      672       +3     
==========================================
+ Hits          488      497       +9     
+ Misses        181      175       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ReubenJ ReubenJ self-requested a review March 26, 2025 07:40
Copy link
Member

@ReubenJ ReubenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if you'd like to merge 👍

@THinnerichs THinnerichs merged commit dfcde0e into master Mar 26, 2025
5 checks passed
@THinnerichs THinnerichs deleted the fix/update_mlfi branch March 26, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants