Make the main script POSIX-compatible #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To that end, wrap the existing test in a for loop.
$HOSTNAME is a bash extension that seems to use the uname syscall just like a plain hostname call does.
This increases the scope of these variables to all functions. All instances have been checked for obvious side effects.
Most importantly, replace regex use in if conditions with most simple parameter expansions and case/esac pattern matching. Additionally, replace all instances of double-bracket ifs with single- bracket versions.
The grep call to test the for legal characters can be replaced by an equivalence check involving a parameter substitution that removes any illegal characters. The other simple cases are simply replaced with echo pipes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think scripts that are supposed as aids in compatibility checks should be most compatible themselves. Therefore I've spent some time on getting rid all the bashism in the main script. Performance is certainly impacted (and most probably slightly negatively) but I've tried to keep everything backward-compatible including the argument checks. All tests keep passing throughout the patch series.