Fix Carrot's reuse function #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jivanam
approved these changes
Oct 1, 2024
MoizIqbal97
approved these changes
Oct 1, 2024
AndyRae
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR added a fix for the Carrot reuse vocabulary function which couldn't reuse multiple concepts added at the same Scan report field or value.
The fix focused on enabling Carrot to handle multiple existing concepts at both the field and value level of an SR.
This PR also added small gaps between concept tags
Closes #626
Screenshots
<screenshot.jpg>
Checks
Important: please complete these before merging.
changelog.md, including migration instructions if any.