Add pre-commit hooks for linting & tests #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently inspired by compiler explorer's pre-commit hooks. Using GitHub Actions to execute tests was consistently holding up my workflow, relying on builders to download our entire toolchain, check syntax, and run tests has been painful to say the least.
This new strategy involves bringing in a dev dependency to install git hooks, which will execute the following in order
This will greatly improve the speed of the development cycle, and prevent having to wait on builders.
Furthermore, we're bringing clippy back as, since it's removal, lots of skeletons I am ashamed of appeared. This patch includes all of the changes to satisfy clippy.