Add -std=c99 when compiling pcre2 sources #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
player-03
approved these changes
Apr 11, 2023
|
Can confirm that (on my machine at least) android-toolchain-gcc fails to compile before making this change, and succeeds after. Edit: and as before, android-toolchain-clang works either way. |
|
Thanks! |
|
One more question: any chance of a hotfix release? As mentioned in the issue, this is breaking Lime's CI builds. |
joshtynjala
added a commit
to openfl/lime
that referenced
this pull request
Apr 17, 2023
player-03
added a commit
to player-03/lime
that referenced
this pull request
Apr 17, 2023
hxcpp 4.3.2 breaks CI builds. The fix has been accepted (see HaxeFoundation/hxcpp#1042), but isn't yet available on Haxelib. Until it is, we can work around the issue by using the previous hxcpp release.
player-03
pushed a commit
to player-03/lime
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1041