Include module path in virtual file names

[kLabz]

When using -D dump-dependencies, macro modules show up with their file names, but for macro generated modules that's unusable (they're all named /server/file_x_y which doesn't help much).

tbh I'm not sure this is the kind of fix we need here, but I also didn't want to break things relying on current -D dump-dependencies output.

[Simn]

We could name these something like defineType/Module_step_counter to make it a bit more human-readable. Where does that /server/ you mention come from?

[Antriel]

The /server/ was from my example. It just includes the full path, and that happened to be the project root. Ideally it would include the package and the module name, but even just the module name is better than nondescript name.

[Simn]

Yes the package should be there too of course. Internally the naming doesn't really matter, the only part that's important is that the file key is unique. So a normal module path with the step and counter suffix would be fine too.

[kLabz]

Printf.sprintf "%s_%i_%i" (s_type_path mpath) step !virtual_counter should do?
Would also be nice to convert that dotpath to directory structure, I suppose

[Antriel]

RE dotpath to directory structure: Yes please. It will be nicer. I could replace dots with slashes on my dependency visualizer, but that would require special handling for .macro.hx and such, which is less nice.

[kLabz]

@Antriel when you have some free time, can you check if that new path works for you?

[Antriel]

Seems to work well, except for modules defined without any package, which end up without the project directory. The difference in those is that the last one has pack: ['reactor'] as part of the type definition.

- C:\Users\peter\Dropbox\work\NextRealm\games\SnowFight\client\file_1_30
- C:\Users\peter\Dropbox\work\NextRealm\games\SnowFight\client\file_1_33
- C:\Users\peter\Dropbox\work\NextRealm\games\SnowFight\client\file_1_76
- C:\Users\peter\Dropbox\work\NextRealm\games\SnowFight\client\file_1_77
+ C:\SerApiUiApi0_1_30
+ C:\SerApiSelfLogicApi0_1_33
+ C:\SerApiManagerClientApi0_1_76
+ C:\Users\peter\Dropbox\work\NextRealm\games\SnowFight\client\reactor\SenderSerApiManagerClientApi00_1_77

[kLabz]

Hmm. I suppose I should handle pack = [] case and use "." there
Thanks!

[Antriel]

Yep, that fixed it.