[hl] Fix interface override function resolution #11723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes HaxeFoundation/hashlink#685
Happens when an interface extends another, and they have a same field (same name, but might have different type, in this case, return type extends parent's return type). Before the fix, tests will fail with
-D hl-checkthen calls a different function / access violation when callingfromBareUser.getStringValue().I'm not sure ifList.sort_uniqwill always keep the first occurrence in the list, but this implementation rely on that. If that's not guaranteed I can implement my own version.Implemented an uniq which keep child's fields before parent's. List.sort is not necessary here but it's used in vfields at other location.