Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Diagnostics] Fix compiler failure when report mode disabled #11704

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Jun 27, 2024

Started with a workaround, but ended up finding the real issue so reverted the workaround; keeping it in history just in case it's needed again later on.

This fixes an "old" (from january) issue that I could only get a clean repro for today:

File "src/core/globals.ml", line 175, characters 1-7: Assertion failed
Compiler failure
Please submit an issue at https://github.com/HaxeFoundation/haxe/issues/new
Attach the following information:
Haxe: 5.0.0-alpha.1+15731ea67; OS type: windows;
File "src/compiler/compiler.ml", line 26, characters 17-24
Called from file "src/compiler/compiler.ml", line 298, characters 2-275
Called from file "src/compiler/compiler.ml", line 365, characters 37-100
Called from file "src/compiler/compiler.ml", line 394, characters 1-5
Called from file "src/compiler/compiler.ml", line 471, characters 2-135
Called from file "src/compiler/compiler.ml", line 445, characters 2-9
Called from file "src/compiler/compiler.ml", line 668, characters 5-43
Called from file "src/compiler/compiler.ml", line 680, characters 13-22
Called from file "src/compiler/server.ml", line 633, characters 1-39
Called from file "src/compiler/server.ml", line 694, characters 3-30
Called from file "src/compiler/compiler.ml", line 668, characters 5-43
Called from file "src/compiler/compiler.ml", line 680, characters 13-22
Called from file "src/compiler/server.ml", line 633, characters 1-39
Called from file "src/compiler/haxe.ml", line 53, characters 0-56

@skial skial mentioned this pull request Jun 27, 2024
1 task
@kLabz kLabz merged commit bda938d into development Jun 27, 2024
99 checks passed
@kLabz kLabz deleted the fix/diagnostics_report_mode_disabled branch January 21, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants