Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macro] do not use dependency file as file for macro created modules #11702

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Jun 24, 2024

TODO:

  • add test demonstrating how things were going wrong
  • use something clean as "fake file"? not sure what right now

@Simn
Copy link
Member

Simn commented Jun 25, 2024

Hmm yes, this makes sense. Perhaps it would be a good idea to enumerate these files so that we can be sure the file keys are unique? I'm not sure in which cases this is actually relevant, but that seems like a good idea either way.

@kLabz kLabz force-pushed the fix/macro_defineType_file branch from 6322d28 to e60fab8 Compare June 25, 2024 13:35
@kLabz
Copy link
Contributor Author

kLabz commented Jun 25, 2024

Hmm yes, this makes sense. Perhaps it would be a good idea to enumerate these files so that we can be sure the file keys are unique? I'm not sure in which cases this is actually relevant, but that seems like a good idea either way.

For sure; though do you have an idea how to actually implement that? (or a starting point)

@Simn
Copy link
Member

Simn commented Jun 25, 2024

Printf.sprintf "file_%i_%i" com.compilation_step com.some_counter would be my first idea.

@kLabz kLabz marked this pull request as ready for review June 25, 2024 15:30
@Simn Simn merged commit 3b36da4 into development Jun 27, 2024
100 checks passed
@kLabz kLabz deleted the fix/macro_defineType_file branch January 21, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants