Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify help messages handling #11584

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Unify help messages handling #11584

merged 2 commits into from
Feb 21, 2024

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Feb 19, 2024

Current situation is a bit weird, with different behavior:

  • --help aborts immediately and goes through message reporting (and can use pretty errors etc)
  • --version goes through message reporting (and can use pretty errors etc) and lets compilation continue (so it's added as a "normal" info message)
  • --help-metas and --help-define directly print to stdout (kinda same for user variants)
Which means we can have these (click to expand)

image

But also this:
image

vs this:
image

And things like mix between raw stdout from --help-metas and message reporting from --version

With this PR, all of the above go through the same path, meaning:

  • None of these would go through message reporting (bye "pretty" --version and --help)
  • They will all abort after printing their content

@Simn Simn merged commit d92f08b into development Feb 21, 2024
98 checks passed
@skial skial mentioned this pull request Feb 21, 2024
1 task
@kLabz kLabz deleted the unify_help_messages_handling branch February 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants