Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation is a bit weird, with different behavior:
--help
aborts immediately and goes through message reporting (and can use pretty errors etc)--version
goes through message reporting (and can use pretty errors etc) and lets compilation continue (so it's added as a "normal" info message)--help-metas
and--help-define
directly print to stdout (kinda same for user variants)Which means we can have these (click to expand)
But also this:
![image](https://private-user-images.githubusercontent.com/6101998/306031592-7ae42f6a-b3c4-471b-808e-e4236c59b706.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwODQxOTUsIm5iZiI6MTczOTA4Mzg5NSwicGF0aCI6Ii82MTAxOTk4LzMwNjAzMTU5Mi03YWU0MmY2YS1iM2M0LTQ3MWItODA4ZS1lNDIzNmM1OWI3MDYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMDY1MTM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODllMDFiZTZlNTZjMTE2NGRmZWE0YTQwYjRiNjAxNmQwM2Y5ZWQxZDNmNzE2NzQ3N2Q5YjhlZTVjODRhNjdjNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.TFgVcUaUs8Nw4GhxKqBbBJGzPT_rmA2R0hGmSAhJxok)
vs this:
![image](https://private-user-images.githubusercontent.com/6101998/306031778-3a3aa624-dffa-4e4c-89ac-48ee08748dbf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwODQxOTUsIm5iZiI6MTczOTA4Mzg5NSwicGF0aCI6Ii82MTAxOTk4LzMwNjAzMTc3OC0zYTNhYTYyNC1kZmZhLTRlNGMtODlhYy00OGVlMDg3NDhkYmYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMDY1MTM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Njc3NmY2YWRkNWE4NWUyMzFkOTQxMTkzNmJmMzRmZTMyMGU0YmVjNWZlOTliZTQxNDc5OTIzOWIzM2MxODhmYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.uENzW5E6Te3rrTjxYlhqJy-p0Htj_Zb79yRYRaV8Lk8)
And things like mix between raw stdout from --help-metas and message reporting from --version
With this PR, all of the above go through the same path, meaning: