Hxb #11266
Closed
Hxb #11266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simn
reviewed
Jun 30, 2023
Simn
reviewed
Jun 30, 2023
| let rec get_reader ctx input mpath p = | ||
| let make_module path file = | ||
| let m = ModuleLevel.make_module ctx path file p in | ||
| m.m_extra.m_processed <- 1; |
There was a problem hiding this comment.
Is this necessary? With the initial compilation_step = 1 it seems fine to leave this at 0.
There was a problem hiding this comment.
is_cached explicitly checks for m.m_processed <> 0
There was a problem hiding this comment.
Yes but is that necessary if the compilation step starts at 1 anyway?
Simn
reviewed
Jun 30, 2023
Simn
reviewed
Jun 30, 2023
39be59a to
5c2162f
Compare
|
I have added some support for local type parameters but I don't know if this is a good approach. Due to the leaky nature of these things it might be better to just enumerate all local type parameters across an entire field and use their identity for indexing. That's not very elegant but should be quite robust and easy to implement. |
Simn
reviewed
Jul 14, 2023
Simn
reviewed
Jul 20, 2023
This reverts commit 71678b2.
|
We will open a new PR from a different branch soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued in #11504
Random TODOs:
¹module_resolutionbranch)¹Current type parameter issues:[unit.TestGADT] Unbound type parameter EBinop.Cwhich can be fixed by commenting out line 282 ofsrc/typing/matcher/exprToPattern.ml(TODO check if doing this is fine)[unit.TestMatch] Unbound type parameter ref.Tand[unit.issues.Issue2889] Unbound type parameter mapMappable.Awhich are linked to type parameters fromFEnum[unit.issues.Issue9661] Unbound type parameter make.Twhich is kind of a weird one (see issue/test)[unit.issues.Issue5385] Unbound type parameter fromIterable.T, about Iterator anon fields being used at two places (because of inline?) with a type parameter that only exists at one place (some leak / mutation that shouldn't apply to the other expr / type parameter cleaning that is not applied to inlined expr ? Issue only happens incf_expr_unoptimized(expr with problem is discarded because unused)