Detect transitive casts #11041
Open
Detect transitive casts #11041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for spending your attention here for silly stuff, basically i wanted to solve this todo somehow:
https://github.com/vshaxe/haxe-language-server/blob/314183133ce3d593b11c702dcd3fada276a3c1d9/src/haxeLanguageServer/protocol/Extensions.hx#L65
So i tried to get
abstracttype param name (likeT1) and check abstractfrom/tocasts, and then buildbool listif type parameter fromct_paramslist is infrom/to, and can be resolved in completion.So completion will work better with params in instances of
abstract EitherType<T1, T2>(Dynamic) from T1 to T1 from T2 to T2 {}and in stuff like
abstract EitherType3<T1, T2, T3>(Dynamic) from T1 to T1 from T2 to T2 from T3 to T3 {}Just interested if there can be less ugly solution and if i understand type casting correctly.