[lua] Modify default lua native bitops library from bit to bit32 #10923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify default lua native bitops library from bit to bit32
|
Thanks! |
tobil4sk
added a commit
to tobil4sk/HaxeManual
that referenced
this pull request
Apr 2, 2023
Lua 5.1 requires installing bit32 manually. [0] Lua 5.2 provides bit32 natively. [1] Lua 5.3 still has it natively, though it is deprecated in favour of native operators. [2] Lua 5.4 removes this library from the standard installation, so it must be installed again. [3] [0] HaxeFoundation/haxe#10923 [1] https://www.lua.org/manual/5.2/manual.html#6.7 [2] http://www.lua.org/manual/5.3/manual.html#8.2 [3] http://www.lua.org/manual/5.4/manual.html#3.4.2
tobil4sk
added a commit
to tobil4sk/HaxeManual
that referenced
this pull request
Apr 5, 2023
Lua 5.1 requires installing bit32 manually. [0] Lua 5.2 provides bit32 natively. [1] Lua 5.3 still has it natively, though it is deprecated in favour of native operators. [2] Lua 5.4 removes this library from the standard installation, so it must be installed again. [3] [0] HaxeFoundation/haxe#10923 [1] https://www.lua.org/manual/5.2/manual.html#6.7 [2] http://www.lua.org/manual/5.3/manual.html#8.2 [3] http://www.lua.org/manual/5.4/manual.html#3.4.2
Simn
pushed a commit
to HaxeFoundation/HaxeManual
that referenced
this pull request
Apr 5, 2023
* Update bit dependency docs for lua Lua 5.1 requires installing bit32 manually. [0] Lua 5.2 provides bit32 natively. [1] Lua 5.3 still has it natively, though it is deprecated in favour of native operators. [2] Lua 5.4 removes this library from the standard installation, so it must be installed again. [3] [0] HaxeFoundation/haxe#10923 [1] https://www.lua.org/manual/5.2/manual.html#6.7 [2] http://www.lua.org/manual/5.3/manual.html#8.2 [3] http://www.lua.org/manual/5.4/manual.html#3.4.2 * Add luasec dependency HaxeFoundation/haxe#10593 * Remove environ dependency HaxeFoundation/haxe@9d75bec * Add hx-lua-simdjson dependency HaxeFoundation/haxe#9885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the default lua native bitops library from bit to bit32.
This resolves a bug with some Lua 5.1 runtimes. In general, on Lua 5.1 the "official" bitops library is bit32 (installed from Luarocks). Some runtimes have backported versions of the 5.2 "bit" library, but these are generally not recommended to use.
Accidentally using the backported version of bit can cause unexpected issues in some Lua runtimes such as Cobalt