Restore macOS 10.13 (High Sierra) support #10778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this was only a theoretical fix to the issue, I felt a little iffy about sending a PR and stating that this "restores macOS 10.13 support" as a fact, so I marked it as a draft at first. I've had the chance to confirm for myself that the binaries this PR produces do run on macOS 10.13, so this is ready to merge. |
|
Could you update this PR so that we can check the CI again? |
pcre is linked into Haxe, so it's important that it honors our macOS deployment target. 43df805 replaced pcre with pcre2. This commit brings pcre back so both are built side by side. This fixes HaxeFoundation#10723
From pcre.org: > Note that the former ftp.pcre.org FTP site is no longer available. and > You can also download PCRE2 or the older, unmaintained PCRE library > from an unofficial mirror at SourceForge: > > https://sourceforge.net/projects/pcre/files/
Until the pcre2 migration is actually done, only build pcre. Context: HaxeFoundation#10491
5c032ef to
009db42
Compare
|
I've updated it. 🫡 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores macOS 10.13 support by ensuring that the pcre code that's linked into Haxe is built from source with the 10.13 deployment target.
This fixes #10723