Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abstract class TODOs #9720

Closed
4 of 5 tasks
Simn opened this issue Jul 16, 2020 · 5 comments
Closed
4 of 5 tasks

abstract class TODOs #9720

Simn opened this issue Jul 16, 2020 · 5 comments
Assignees
@Simn
Milestone
Release 4.2

Comments

@Simn
Copy link
Member

Simn commented Jul 16, 2020 •
edited by RealyUniqueName
Loading

  • check abstract override: This is fine and is also allowed by other languages.
  • check constructors
  • add isAbstract flags to functions and classes in the display API
  • add isAbstract flags to functions and classes in the XML output for dox
  • add isAbstract flags to functions and classes in the macro API
@Simn Simn self-assigned this Jul 16, 2020
@RealyUniqueName RealyUniqueName added this to the Release 4.2 milestone Jul 16, 2020
@Gama11 Gama11 mentioned this issue Jul 16, 2020
Closed
@Simn
Copy link
Member Author

Simn commented Jul 17, 2020

Another open question is if override should be required to implement an abstract method of a parent class. I don't really have a strong opinion on that and can see arguments for both sides.

@RealyUniqueName
Copy link
Member

There was a discussion on that matter in the evolution thread starting from this message

@RealyUniqueName
Copy link
Member

add isAbstract flags to functions and classes in the macro API

Isn't this solved by AAbstract accessor?

@Gama11
Copy link
Member

Gama11 commented Jul 17, 2020

Isn't this solved by AAbstract accessor?

Still missing from haxe.macor.Type.ClassType and such as far as I can tell?

RealyUniqueName added a commit that referenced this issue Dec 16, 2020
@RealyUniqueName
added isAbstract to structs in haxe.macro.Type (#9720)
da80ab2
RealyUniqueName added a commit that referenced this issue Dec 16, 2020
@RealyUniqueName
added isAbstract to display protocol (#9720)
1fc53be
RealyUniqueName added a commit that referenced this issue Dec 16, 2020
@RealyUniqueName
added class/field abstract info to genxml (#9720)
e0634f6
@RealyUniqueName
Copy link
Member

Since nobody knows what does "check constructors" mean I consider this issue resolved.

RealyUniqueName added a commit that referenced this issue Dec 18, 2020
@RealyUniqueName
update haxe.display for isAbstract (#9720)
82fd973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simn Simn

Labels
None yet
Projects
None yet
Milestone
Release 4.2
Development

No branches or pull requests
3 participants
@Simn @Gama11 @RealyUniqueName