Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eval] Unicode issue when splitting string #6897

Closed
markknol opened this issue Mar 8, 2018 · 7 comments
Closed

[eval] Unicode issue when splitting string #6897

markknol opened this issue Mar 8, 2018 · 7 comments
Assignees
Labels
platform-eval Everything related to the Haxe 4 eval macro interpreter regression unicode
Milestone

Comments

@markknol
Copy link
Member

markknol commented Mar 8, 2018

var inChars   = 'àáâãäçèéêëìíîïñòóôõöùúûüýÿ'.split('');
var outChars  = 'aaaaaceeeeiiiinooooouuuuyy'.split('');
trace(inChars.length, outChars.length);

Test case online https://try.haxe.org/#9B7E2 (works as expected)
In Haxe 3 --interp it logs 26,26 (works as expected)
In Haxe 4 Preview 3 --interp it logs 52,26 (unexpected length of first array)

@markknol markknol added regression platform-eval Everything related to the Haxe 4 eval macro interpreter unicode labels Mar 8, 2018
@Simn Simn self-assigned this Apr 16, 2018
@Simn
Copy link
Member

Simn commented Apr 16, 2018

I don't really understand why this used to work because it fails on neko as well. It also fails on php and lua.

@ncannasse
Copy link
Member

Should be straightforward now with dual string implementation

@Simn
Copy link
Member

Simn commented Sep 3, 2018

Yes this works fine on the unicode branch. I still have no idea why it worked on the old interpreter, but whatever...

@axelhuizinga
Copy link

Are anywhere unicode builds available?

@Simn
Copy link
Member

Simn commented Sep 4, 2018

Not yet, but I'll merge the branch soon.

@Simn
Copy link
Member

Simn commented Sep 4, 2018

The branch has been merged and the test passes now.

@Simn Simn closed this as completed Sep 4, 2018
@markknol
Copy link
Member Author

markknol commented Sep 4, 2018

Thanks for this! You rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-eval Everything related to the Haxe 4 eval macro interpreter regression unicode
Projects
None yet
Development

No branches or pull requests

4 participants