Use array_fill for php

HaxeFoundation · Mar 1, 2023 · 2832d33 · 2832d33
1 parent 8f3a88a
commit 2832d33
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/std/php/_std/haxe/ds/Vector.hx b/std/php/_std/haxe/ds/Vector.hx
@@ -28,9 +28,9 @@ private class PhpVectorData<T> {
 	public var length:Int;
 	public var data:NativeIndexedArray<T>;
 
-	public inline function new(length:Int) {
+	public inline function new(length:Int, data:NativeIndexedArray<T>) {
 		this.length = length;
-		data = new NativeIndexedArray();
+		this.data = data;
 	}
 }
 
@@ -41,13 +41,11 @@ abstract Vector<T>(VectorData<T>) {
 	public var length(get, never):Int;
 
 	public inline function new(length:Int) {
-		this = new VectorData(length);
+		this = new VectorData(length, new NativeIndexedArray());
 	}
 
 	public static inline function createFilled<T>(length:Int, defaultValue:T):Vector<T> {
-		final vector = new Vector(length);
-		vector.fill(defaultValue);
-		return vector;
+		return cast new VectorData(length, Global.array_fill(0, length, defaultValue));
 	}
 
 	@:op([]) public inline function get(index:Int):T {
@@ -63,7 +61,7 @@ abstract Vector<T>(VectorData<T>) {
 	}
 
 	public inline function fill(value:T):Void
-		for (i in 0...length) this.data[i] = value;
+		this.data = Global.array_fill(0, length, value);
 
 	public static function blit<T>(src:Vector<T>, srcPos:Int, dest:Vector<T>, destPos:Int, len:Int):Void {
 		if (src == dest) {
@@ -109,8 +107,7 @@ abstract Vector<T>(VectorData<T>) {
 	}
 
 	static public inline function fromArrayCopy<T>(array:Array<T>):Vector<T> {
-		var vectorData = new VectorData(array.length);
-		vectorData.data = @:privateAccess array.arr;
+		var vectorData = new VectorData(array.length, @:privateAccess array.arr);
 		return cast vectorData;
 	}