Easier build on M1 take 2 #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if there are any requested changes to this PR. |
|
Removing |
|
Note that those flags are only needed for 32-bit x86, for 64-bit x86 SSE is the default. |
|
Thanks for the feedback. I'll work on the updates. |
|
@Apprentice-Alchemist, let me know if you have any concerns with that approach. |
|
Looks good to me. |
Closed
|
I can't really review this, but it doesn't break CI and seems to make various people happy, so I'll merge it! |
crazyjul
pushed a commit
to playdigious/hashlink
that referenced
this pull request
Jan 18, 2024
* Initial changes to build Hashlink on Mac arm64. * Only include mdbg on the x86_64. * Re-added build flags for 32 bit architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based closely on nullobsi PR but addresses the issue waaadim identified.