Feature - Mac profiler support #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a mac to test against. Is this complete and fully working or still wip ? |
|
It is complete. I am using it myself to profile. |
|
It adds two fields to the thread struct in hl.h. This will mean that any Mac binaries or hdll's must be recompiled against the new hl.h to work, which isn't a problem for a full rebuild of hl like the automated builds do. However, anyone that makes custom Mac hdll's must rebuild them. |
|
Thanks for the contribution ! |
|
It works on Intel machines, doesn't seem to work on M1 machines. When I have some free time, I'll poke at it and see if I can figure it out. I'd really like to be able to use it. Printf/trace debugging sucks. |
Closed
crazyjul
pushed a commit
to playdigious/hashlink
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the necessary conditional logic to support the Hashlink profiler on Mac (Intel Only).