Deprecate sound.group setter, avoiding recursion errors #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore Nightly CI: openfl/lime#1763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destroying sounds created via FlxG.sound.load in substates get destroyed but not removed from the groups, later when destroying the state they are removed from their groups causing a null ref via updateTransform
I've deprecated the sound.group setter, this is a pretty terrible system and many parts of the code have to walk on egg shells to avoid unintended recursion, and it provides almost no real benefit over simple calls to
group.add(sound)(which will still remove it from prior groups)