added wrapping location to allow wrapping before delimiter, fixes #299 #309
Conversation
…xeCheckstyle#299 fixed anon types and leftCurly=both, fixes HaxeCheckstyle#301 fixed same line handling of expressionIf, fixes HaxeCheckstyle#304 fixed indentation of object literals, fixes HaxeCheckstyle#305 fixed same line handling of cases with object patterns, fixes HaxeCheckstyle#306 fixed empty line after class metadata with function, fixes HaxeCheckstyle#307 fixed missing space between Comman and POpen, fixes HaxeCheckstyle#308 refactored to increase null safety
|
Hm, are you even using code from the safety lib anywhere? I mostly see |
|
I think it's only in two places and haxe 3.x build is still broken, I might drop it for now... |
|
Would also make it a dependency for vshaxe. |
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 88.98% 88.92% -0.07%
==========================================
Files 17 17
Lines 5084 5226 +142
Branches 230 239 +9
==========================================
+ Hits 4524 4647 +123
- Misses 330 340 +10
- Partials 230 239 +9
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 88.98% 88.92% -0.07%
==========================================
Files 17 17
Lines 5084 5226 +142
Branches 230 239 +9
==========================================
+ Hits 4524 4647 +123
- Misses 330 340 +10
- Partials 230 239 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 88.98% 88.98% -0.01%
==========================================
Files 17 17
Lines 5084 5229 +145
Branches 230 239 +9
==========================================
+ Hits 4524 4653 +129
- Misses 330 337 +7
- Partials 230 239 +9
Continue to review full report at Codecov.
|
yeah, maybe not a good idea |
|
What's with all those codecov reports? Is that a bug, or is there one for each commit? :D |
|
I think they used to post just one and they updated it when new results came in, apparently they just post a fresh one everytime nowadays. |
|
ok, we had two webhooks for codecov in there, I deleted one, we'll see if that fixes it when the next PR happens... |
fixed anon types and
leftCurly=both, fixes #301fixed same line handling of
expressionIf, fixes #304fixed indentation of object literals, fixes #305
fixed same line handling of cases with object patterns, fixes #306
fixed empty line after class metadata with function, fixes #307
fixed missing space between Comma and POpen, fixes #308
refactored to increase null safety