Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overload modifier support #626

Closed
Gama11 opened this issue Dec 19, 2020 · 1 comment
Closed

overload modifier support #626

Gama11 opened this issue Dec 19, 2020 · 1 comment
Labels
bug Something isn't working tokentree requires fix in tokentree

Comments

@Gama11
Copy link
Member

Gama11 commented Dec 19, 2020

The overload modifier currently seems to trigger a line break:

class Foo {
	static
	overload extern inline function foo() {}

	overload
	static extern inline function foo(i:Int) {}
}
@Gama11 Gama11 added the bug Something isn't working label Dec 19, 2020
@AlexHaxe
Copy link
Member

yep, that's caused by haxeparser (and by extension tokentree) being mostly unaware of new nightly features

spoiler alert: I'm in the process of updating haxeparser and then tokentree.

I've already patched and PR'd munit. utest thankfully has a patch for spread operator. json2object needs a fix for new isAbstract field in ClassType.

@AlexHaxe AlexHaxe added the tokentree requires fix in tokentree label Dec 19, 2020
AlexHaxe added a commit to AlexHaxe/haxe-formatter that referenced this issue Dec 20, 2020
@AlexHaxe
fixed overload support, fixes HaxeCheckstyle#626
ab489f9 
updated to latest haxeparser and tokentreee
retired Haxe 3.4.7 compilation support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tokentree requires fix in tokentree
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gama11 @AlexHaxe