Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning from CakePHP 3.6 #15

Merged
merged 10 commits into from
Apr 23, 2018

Conversation

ludeus
Copy link
Contributor

@ludeus ludeus commented Apr 18, 2018

Please note that testMain() and testMainPlugin() from tests/TestCase/Shell/Task/MaintenanceModeTaskTest.php has been disabled.
The cake/bake plugin use Twig/Twig now, and I have lot of unresolved issues with that tests. I can't spend more time on it.

@codecov-io
Copy link

codecov-io commented Apr 18, 2018

Codecov Report

Merging #15 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #15     +/-   ##
===========================================
- Coverage     95.23%   95.14%   -0.1%     
  Complexity       44       44             
===========================================
  Files             7        7             
  Lines           105      103      -2     
===========================================
- Hits            100       98      -2     
  Misses            5        5
Impacted Files Coverage Δ Complexity Δ
src/Mode/View.php 93.75% <100%> (ø) 3 <0> (ø) ⬇️
src/Mode/Redirect.php 100% <100%> (ø) 3 <0> (ø) ⬇️
src/Middleware/MaintenanceMiddleware.php 89.47% <100%> (-0.27%) 22 <0> (ø)
src/Mode/Mode.php 100% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b9c4b6...5c53fca. Read the comment docs.

@ludeus
Copy link
Contributor Author

ludeus commented Apr 18, 2018

Note that CakePHP 3.6 require PHP >= 5.6, no more 5.5. It is why the build failed.

@HavokInspiration
Copy link
Owner

I pushed a bunch of commits on top of your PR to take care of Bake, the failing builds and updating the README.

I'll release a new 3.0.0 version of the plugin today, when all builds pass.

Thanks a lot for your work updating the plugin !

@HavokInspiration HavokInspiration merged commit 8e2c42a into HavokInspiration:master Apr 23, 2018
@HavokInspiration
Copy link
Owner

@ludeus Version 3.0.0 just released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants