-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecation warning from CakePHP 3.6 #15
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
===========================================
- Coverage 95.23% 95.14% -0.1%
Complexity 44 44
===========================================
Files 7 7
Lines 105 103 -2
===========================================
- Hits 100 98 -2
Misses 5 5
Continue to review full report at Codecov.
|
Note that CakePHP 3.6 require PHP >= 5.6, no more 5.5. It is why the build failed. |
I pushed a bunch of commits on top of your PR to take care of Bake, the failing builds and updating the README. I'll release a new 3.0.0 version of the plugin today, when all builds pass. Thanks a lot for your work updating the plugin ! |
@ludeus Version 3.0.0 just released. |
Please note that testMain() and testMainPlugin() from tests/TestCase/Shell/Task/MaintenanceModeTaskTest.php has been disabled.
The cake/bake plugin use Twig/Twig now, and I have lot of unresolved issues with that tests. I can't spend more time on it.