Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(qa): add large values QA #710

Merged
merged 2 commits into from
Jan 7, 2025
Merged

docs(qa): add large values QA #710

merged 2 commits into from
Jan 7, 2025

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Dec 20, 2024

Motivation

Since the wallet-desktop currently doesn't have automated tests, this PR adds a new QA to make specific checks when handling large output values (BigInt). It introduces a docker compose that runs a complete custom network (full node, tx-mining-service, and CPU miner). The new QA described in QA_LARGE_VALUES.md should be incorporated as part of the QA process for this project.

Acceptance Criteria

  • Add new QA_LARGE_VALUES.md.
  • Change debug command in README to use equivalent npm script.
  • Add new QA npm scripts config.
  • Add new QA python script, docker compose, and custom network config files.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@glevco glevco self-assigned this Dec 20, 2024
@glevco glevco marked this pull request as ready for review December 20, 2024 22:04
pedroferreira1
pedroferreira1 previously approved these changes Jan 7, 2025
QA_LARGE_VALUES.md Outdated Show resolved Hide resolved
tuliomir
tuliomir previously approved these changes Jan 7, 2025
qa/large-values-network/checks.py Outdated Show resolved Hide resolved
Co-authored-by: Pedro Ferreira <pedro@hathor.network>
@tuliomir tuliomir dismissed stale reviews from pedroferreira1 and themself via ed61bf0 January 7, 2025 22:46
@tuliomir tuliomir merged commit 9f4abcc into master Jan 7, 2025
2 checks passed
@tuliomir tuliomir deleted the docs/large-values-qa branch January 7, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants