-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf/integration tests: Preparing for precalculated wallet addresses lib feature #189
Conversation
This pull request introduces 1 alert when merging 475875b into ae1396d - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## dev #189 +/- ##
==========================================
+ Coverage 85.84% 86.32% +0.48%
==========================================
Files 19 18 -1
Lines 650 651 +1
Branches 133 134 +1
==========================================
+ Hits 558 562 +4
+ Misses 83 80 -3
Partials 9 9
Continue to review full report at Codecov.
|
About the utils, I agree they should be moved to a scripts folder. This was done on ed0d3e1. About the precalculation helper, that is still on the
|
Before, the full wallet constructor was being used.
Before they were generated using the complete wallet instance.
A new feature on the wallet-lib will allow wallets to have their addresses pre-calculated to save up on processing time at the integration tests.
This PR contains the code adaptations to use this feature, as designed by:
Once the wallet lib is updated with the address pre-calculation feature, the following average time improvements are expected:
More details on this available on the 173 design.
With this change alone, runs will be executed in around 500 seconds, a gain of near 50% from the original ~1000 seconds.
The lib version bump will be made in a separate PR.
Summary of changes
WalletHelper
to use ittest-utils-integration.js
methods were refactored to use themWalletHelper.startMultipleWalletsForTest
method was simplifiedcore.util.js
filesrc/utils
toscripts/
Acceptance Criteria
Security Checklist