Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show token metadata #86

Merged
merged 5 commits into from
Aug 11, 2021
Merged

feat: show token metadata #86

merged 5 commits into from
Aug 11, 2021

Conversation

justgigio
Copy link
Contributor

@justgigio justgigio commented Jul 8, 2021

This is the first screen proposal.

When everybody approve this proposal and HathorNetwork/hathor-explorer-service#40 , i can add the request and finish.

Scam Token

image

Verified Token

image

Others

image

@justgigio justgigio self-assigned this Jul 8, 2021
@justgigio justgigio linked an issue Jul 8, 2021 that may be closed by this pull request
@justgigio justgigio changed the title feat: show info proposal feat: show token metadata Jul 8, 2021
@justgigio justgigio requested a review from a team July 8, 2021 23:17
src/components/token/TokenAlerts.js Outdated Show resolved Hide resolved
src/components/token/TokenAlerts.js Outdated Show resolved Hide resolved
src/components/token/TokenAlerts.js Outdated Show resolved Hide resolved
src/components/token/TokenAlerts.js Outdated Show resolved Hide resolved
@obiyankenobi
Copy link
Member

obiyankenobi commented Jul 15, 2021

Did you discuss what are the requirements of a verified token? What's the process to do it? I understand this is more of a business decision.

@pedroferreira1 @msbrogli

Also, screenshots seem to be outdated. Could you please update it?

@justgigio
Copy link
Contributor Author

@obiyankenobi updated and added some verified options

@obiyankenobi
Copy link
Member

@obiyankenobi updated and added some verified options

I like option 2.

@msbrogli
Copy link
Member

I like option 2 as well. Besides the content of the message, is there anything else left to be done here? @giovanecosta

src/components/token/TokenMarkers.js Outdated Show resolved Hide resolved
src/components/token/TokenAlerts.js Outdated Show resolved Hide resolved
src/components/token/TokenAlerts.js Outdated Show resolved Hide resolved
src/components/token/TokenMarkers.js Outdated Show resolved Hide resolved
src/components/token/TokenMarkers.js Outdated Show resolved Hide resolved
@justgigio justgigio force-pushed the feat/show-token-metadata branch from 6665d6f to 7d9de41 Compare July 27, 2021 17:56
@justgigio justgigio requested a review from pedroferreira1 July 27, 2021 17:58
pedroferreira1
pedroferreira1 previously approved these changes Jul 28, 2021
src/components/Network.js Outdated Show resolved Hide resolved
src/components/token/TokenAlerts.js Outdated Show resolved Hide resolved
@msbrogli msbrogli requested review from obiyankenobi and removed request for obiyankenobi August 9, 2021 19:53
@justgigio justgigio merged commit f96b3ad into dev Aug 11, 2021
@r4mmer r4mmer deleted the feat/show-token-metadata branch September 14, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Metadata Info in Token Page
4 participants