Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tx): app load screen #53

Merged
merged 6 commits into from
May 26, 2021
Merged

feat(tx): app load screen #53

merged 6 commits into from
May 26, 2021

Conversation

justgigio
Copy link
Contributor

@justgigio justgigio commented May 12, 2021

When some error occur with API:

scrnli_5_14_2021_11-24-23.AM.mov

Expected behavior (slow 3G emulated):

scrnli_5_14_2021_11-19-32.AM.mov

Changing pages while loading:

scrnli_5_14_2021_11-20-09.AM.mov

Taking more than 3 seconds to load:

scrnli_5_20_2021_4-01-23.PM.mp4

@justgigio justgigio self-assigned this May 12, 2021
@pedroferreira1 pedroferreira1 changed the base branch from master to dev May 12, 2021 20:13
@justgigio justgigio marked this pull request as ready for review May 14, 2021 14:37
@justgigio justgigio changed the title Feat/app load screen feat(tx): app load screen May 14, 2021
@justgigio justgigio requested a review from andreabadesso May 14, 2021 16:58
pedroferreira1
pedroferreira1 previously approved these changes May 17, 2021
src/App.js Show resolved Hide resolved
src/actions/index.js Outdated Show resolved Hide resolved
src/components/Loading.js Show resolved Hide resolved
src/App.js Show resolved Hide resolved
andreabadesso
andreabadesso previously approved these changes May 17, 2021
@justgigio justgigio dismissed stale reviews from andreabadesso and pedroferreira1 via b5883ab May 17, 2021 19:40
@andreabadesso andreabadesso self-requested a review May 17, 2021 19:46
andreabadesso
andreabadesso previously approved these changes May 17, 2021
msbrogli
msbrogli previously approved these changes May 18, 2021
src/App.js Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
src/components/Loading.js Show resolved Hide resolved
pedroferreira1
pedroferreira1 previously approved these changes May 24, 2021
src/components/Loading.js Show resolved Hide resolved
andreabadesso
andreabadesso previously approved these changes May 24, 2021
@justgigio justgigio dismissed stale reviews from andreabadesso and pedroferreira1 via 6b3286f May 26, 2021 14:15
@andreabadesso andreabadesso self-requested a review May 26, 2021 14:32
@pedroferreira1 pedroferreira1 self-requested a review May 26, 2021 17:46
@justgigio justgigio merged commit 9880a43 into dev May 26, 2021
@r4mmer r4mmer deleted the feat/app-load-screen branch September 14, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants