-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: using node version 13 in github workflow #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The node-sass repo starts with a warning
Warning: LibSass and Node Sass are deprecated.
While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features.
Projects that still use it should move onto Dart Sass.
Should we start moving to Dart Sass?
.github/workflows/deploy.yml
Outdated
uses: actions/setup-node@v1 | ||
with: | ||
node-version: 14.x | ||
node-version: 13.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should use version 12 instead of 13, because 13 is not supported anymore: https://nodejs.org/en/about/releases/
12 will be supported until april 2022.
In the meatime, I think we should do what r4mmer suggested, so we are able to move to newer Node.js versions in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created an issue to handle this in the future: #145 |
Motivation
After the release of v0.10.0 we had a problem with the deploy of the explorer version. https://github.com/HathorNetwork/hathor-explorer/runs/4432263445?check_suite_focus=true
The node-sass package could not be installed and the link with supported versions (https://github.com/sass/node-sass/releases/tag/v4.13.1) shows that this package does not support node 14