feat(tx): implements token handler #14
Conversation
gateways/clients/responses/hathor_core/hathor_core_token_response.py
Outdated
Show resolved
Hide resolved
| raise Exception('not_found') | ||
|
|
||
| return { | ||
| "statusCode": 200, |
There was a problem hiding this comment.
In case response.status_code (or .status, or whatever else it's called) is not 200, what do we do? Shouldn't we just forward the response status code or at least error when it isn't 200?
There was a problem hiding this comment.
The exception above will lead to a 404
There was a problem hiding this comment.
Is it possible that response != None and still response.status_code != 200, couldn't an error (404/500/...) on get_token.get have some response that is not None?
Either way I think we should try to improve this in the future, using a wrapper is great, but using bare Exceptions isn't that great, I think specific exception classes are much better. Or we could also use something like aiohttp that has a good set of handy features like those exceptions classes.
No description provided.